3835 zfs need not store 2 copies of all metadata

[Christopher Siden]

http://reviews.csiden.org/r/12/

Note about reviewboard:
I'm going to start posting diffs using reviewboard instead of webrevs, it's
much easier for me to track what I have out for review and what feedback I
need to respond to when I have multiple reviews out at the same time. If
you want you can continue send feedback via email, but it would make my
life much easier if you registered for an account on that reviewboard
server (http://reviews.csiden.org/account/register/) and provide your
feedback there (
http://www.reviewboard.org/docs/manual/1.7/users/reviews/reviewing-diffs/).
I think you'll find the review process goes much nicer in reviewboard than
over email. Also, once you've registered feel free to use that reviewboard
instance for your own reviews for illumos-gate as well (
http://www.reviewboard.org/docs/rbtools/dev/).

Chris



-------------------------------------------
illumos-zfs
Archives: https://www.listbox.com/member/archive/182191/=now
RSS Feed: https://www.listbox.com/member/archive/rss/182191/23047029-187a0c8d
Modify Your Subscription: https://www.listbox.com/member/?member_id=23047029&id_secret=23047029-2e85923f
Powered by Listbox: http://www.listbox.com

[Jim Klimov]

Post by Christopher Siden
http://reviews.csiden.org/r/12/
I'm going to start posting diffs using reviewboard instead of webrevs, it's
much easier for me to track what I have out for review and what
feedback I
need to respond to when I have multiple reviews out at the same time. If
you want you can continue send feedback via email, but it would make my
life much easier if you registered for an account on that reviewboard
server (http://reviews.csiden.org/account/register/) and provide your
feedback there (
http://www.reviewboard.org/docs/manual/1.7/users/reviews/reviewing-diffs/).
I think you'll find the review process goes much nicer in reviewboard than
over email. Also, once you've registered feel free to use that
reviewboard
instance for your own reviews for illumos-gate as well (
http://www.reviewboard.org/docs/rbtools/dev/).
Chris
-------------------------------------------
illumos-zfs
Archives: https://www.listbox.com/member/archive/182191/=now
https://www.listbox.com/member/archive/rss/182191/22497542-d75cd9d9
https://www.listbox.com/member/?&
Powered by Listbox: http://www.listbox.com

Wouldn't it make sense to have discussions in email (or at least an automated copy of submitted comments to be posted to the lists) as a means of archiving for posterity? That is, what if your reviewboard goes down tomorrow or in a couple of years? Would we have a trace as to what and why was decided for various features? The mailing lists tend to have several archiving subscribers (in that googling hits quite a few copies of our posts from many years back); probably the internet archive has some too. Would this be the case with this new media?

And/or would it make sense to host one with illumos.org or openzfs.org?

Thanks,
//Jim
--
Typos courtesy of K-9 Mail on my Samsung Android

[Christopher Siden]

We currently have no general archive of reviews, sure some reviews happen
on the mailing list, but plenty of them happen via private email once the
webrev is sent out, and the webrevs themselves are scattered across various
servers, overwritten every time the review is updated, and not preserved
once the change is pushed, so at least as far as code reviews go we're left
with some subset of review comments in an email archive referencing line
numbers in webrevs that are no longer available.

Reviewboard might be a good place to archive discussions around specific
pieces of code, but that's not what it's for right now, it's just an
alternate way of doing reviews that is an incremental improvement over
webrevs for me, without being worse than webrevs in other respects.

If people outside of Delphix start using this reviewboard instance I'm fine
with maintaining it more properly so that it remains accessible and moving
the domain to something more reasonable so that links continue functioning
even if we move the site to someone else's servers. I've already discussed
having reviews.open-zfs.org point to this server with Matt, and that's
going to happen, I don't know about reviews.illumos.org.

As far as sending automated email goes, that was the next thing I was going
to look in to, it should be fairly easy to configure reviewboard so that
people posting reviews can opt-in to having information about the review
and any comments also sent to a specific mailing list (e.g. if you posted a
ZFS review instead of emailing "***@lists.illumos.org" manually you would
tell reviewboard to include the "zfs" review group and it would
automatically send email to the mailing list with info about the review and
comments). I just wanted to start with only reviewboard for my first batch
of pushes, but in the next batch I'll try this out and see what people
think about the email it generates, it should have the same level of noise
that doing reviews over email does (we use this feature internally at
Delphix to get updates about reviews).

Chris

Post by Jim Klimov

Post by Christopher Siden
http://reviews.csiden.org/r/12/
I'm going to start posting diffs using reviewboard instead of webrevs, it's
much easier for me to track what I have out for review and what feedback I
need to respond to when I have multiple reviews out at the same time. If
you want you can continue send feedback via email, but it would make my
life much easier if you registered for an account on that reviewboard
server (http://reviews.csiden.org/account/register/) and provide your
feedback there (
http://www.reviewboard.org/docs/manual/1.7/users/reviews/reviewing-diffs/

).

Post by Christopher Siden
I think you'll find the review process goes much nicer in reviewboard than
over email. Also, once you've registered feel free to use that reviewboard
instance for your own reviews for illumos-gate as well (
http://www.reviewboard.org/docs/rbtools/dev/).
Chris
-------------------------------------------
illumos-zfs
Archives: https://www.listbox.com/member/archive/182191/=now
https://www.listbox.com/member/archive/rss/182191/22497542-d75cd9d9
https://www.listbox.com/member/?&
Powered by Listbox: http://www.listbox.com

Wouldn't it make sense to have discussions in email (or at least an
automated copy of submitted comments to be posted to the lists) as a means
of archiving for posterity? That is, what if your reviewboard goes down
tomorrow or in a couple of years? Would we have a trace as to what and why
was decided for various features? The mailing lists tend to have several
archiving subscribers (in that googling hits quite a few copies of our
posts from many years back); probably the internet archive has some too.
Would this be the case with this new media?
And/or would it make sense to host one with illumos.org or openzfs.org?
Thanks,
//Jim
--
Typos courtesy of K-9 Mail on my Samsung Android
-------------------------------------------
illumos-zfs
Archives: https://www.listbox.com/member/archive/182191/=now
https://www.listbox.com/member/archive/rss/182191/21639088-b97104e3
https://www.listbox.com/member/?&
Powered by Listbox: http://www.listbox.com

-------------------------------------------
illumos-zfs
Archives: https://www.listbox.com/member/archive/182191/=now
RSS Feed: https://www.listbox.com/member/archive/rss/182191/23047029-187a0c8d
Modify Your Subscription: https://www.listbox.com/member/?member_id=23047029&id_secret=23047029-2e85923f
Powered by Listbox: http://www.listbox.com