Discussion:
zpool import -t
Richard Yao
2014-03-10 21:32:50 UTC
Permalink
I have sent this patch to ZoL in a pull request. It includes a second
patch to remove an option that does not appear to be used. Feedback is
welcome, although I think there is not much to say about this.

https://github.com/zfsonlinux/zfs/pull/2178




-------------------------------------------
illumos-zfs
Archives: https://www.listbox.com/member/archive/182191/=now
RSS Feed: https://www.listbox.com/member/archive/rss/182191/23047029-187a0c8d
Modify Your Subscription: https://www.listbox.com/member/?member_id=23047029&id_secret=23047029-2e85923f
Powered by Listbox: http://www.listbox.com
Xin Li
2014-03-11 00:39:43 UTC
Permalink
Post by Richard Yao
I have sent this patch to ZoL in a pull request. It includes a
second patch to remove an option that does not appear to be used.
Feedback is welcome, although I think there is not much to say
about this.
https://github.com/zfsonlinux/zfs/pull/2178
I think both changes are good (the second one could probably be
improved by choosing a different name than spa_name and consistently
use spa_name(spa), by the way).

Cheers,
- --
Xin LI <***@delphij.net> https://www.delphij.net/
FreeBSD - The Power to Serve! Live free or die
Richard Yao
2014-03-13 22:06:08 UTC
Permalink
I have refreshed the patch in a new pull request, which should address
your feedback.

https://github.com/zfsonlinux/zfs/pull/2189
Post by Xin Li
Post by Richard Yao
I have sent this patch to ZoL in a pull request. It includes a
second patch to remove an option that does not appear to be used.
Feedback is welcome, although I think there is not much to say
about this.
https://github.com/zfsonlinux/zfs/pull/2178
I think both changes are good (the second one could probably be
improved by choosing a different name than spa_name and consistently
use spa_name(spa), by the way).
Cheers,
-------------------------------------------
illumos-zfs
Archives: https://www.listbox.com/member/archive/182191/=now
RSS Feed: https://www.listbox.com/member/archive/rss/182191/24010604-91e32bd2
Modify Your Subscription: https://www.listbox.com/member/?&
Powered by Listbox: http://www.listbox.com
-------------------------------------------
illumos-zfs
Archives: https://www.listbox.com/member/archive/182191/=now
RSS Feed: https://www.listbox.com/member/archive/rss/182191/23047029-187a0c8d
Modify Your Subscription: https://www.listbox.com/member/?member_id=23047029&id_secret=23047029-2e85923f
Powered by Listbox: http://www.listbox.com

Matthew Ahrens
2014-03-13 08:57:25 UTC
Permalink
changes look reasonable to me.

--matt
Post by Richard Yao
I have sent this patch to ZoL in a pull request. It includes a second
patch to remove an option that does not appear to be used. Feedback is
welcome, although I think there is not much to say about this.
https://github.com/zfsonlinux/zfs/pull/2178
-------------------------------------------
illumos-zfs
Archives: https://www.listbox.com/member/archive/182191/=now
https://www.listbox.com/member/archive/rss/182191/21635000-ebd1d460
https://www.listbox.com/member/?&
Powered by Listbox: http://www.listbox.com
-------------------------------------------
illumos-zfs
Archives: https://www.listbox.com/member/archive/182191/=now
RSS Feed: https://www.listbox.com/member/archive/rss/182191/23047029-187a0c8d
Modify Your Subscription: https://www.listbox.com/member/?member_id=23047029&id_secret=23047029-2e85923f
Powered by Listbox: http://www.listbox.com
Loading...