Discussion:
[review request] 5149 zvols need a way to ignore DKIOCFREE
Matthew Ahrens via illumos-zfs
2014-09-11 04:43:28 UTC
Permalink
5149 zvols need a way to ignore DKIOCFREE

https://reviews.csiden.org/r/92/

--matt



-------------------------------------------
illumos-zfs
Archives: https://www.listbox.com/member/archive/182191/=now
RSS Feed: https://www.listbox.com/member/archive/rss/182191/23047029-187a0c8d
Modify Your Subscription: https://www.listbox.com/member/?member_id=23047029&id_secret=23047029-2e85923f
Powered by Listbox: http://www.listbox.com
Dan McDonald via illumos-zfs
2014-09-11 04:58:07 UTC
Permalink
Post by Matthew Ahrens via illumos-zfs
5149 zvols need a way to ignore DKIOCFREE
https://reviews.csiden.org/r/92/
Approved.

Dan
Dan McDonald via illumos-zfs
2014-09-11 04:58:41 UTC
Permalink
Dammit, I thought this was an RTI. So many of 'em today...

s/Approved/Ship it/g.

Dan
Etienne Dechamps via illumos-zfs
2014-09-11 09:46:23 UTC
Permalink
On Thu, Sep 11, 2014 at 5:43 AM, Matthew Ahrens via illumos-zfs
Post by Matthew Ahrens via illumos-zfs
5149 zvols need a way to ignore DKIOCFREE
https://reviews.csiden.org/r/92/
What is the reason for disabling that feature by default?
Matthew Ahrens via illumos-zfs
2014-09-11 15:30:27 UTC
Permalink
Post by Etienne Dechamps via illumos-zfs
On Thu, Sep 11, 2014 at 5:43 AM, Matthew Ahrens via illumos-zfs
Post by Matthew Ahrens via illumos-zfs
5149 zvols need a way to ignore DKIOCFREE
https://reviews.csiden.org/r/92/
What is the reason for disabling that feature by default?
Whoops, this should not be disabled by default. Will update the review.

--matt



-------------------------------------------
illumos-zfs
Archives: https://www.listbox.com/member/archive/182191/=now
RSS Feed: https://www.listbox.com/member/archive/rss/182191/23047029-187a0c8d
Modify Your Subscription: https://www.listbox.com/member/?member_id=23047029&id_secret=23047029-2e85923f
Powered by Listbox: http://www.listbox.com
Richard Elling via illumos-zfs
2014-09-11 14:03:32 UTC
Permalink
Post by Matthew Ahrens via illumos-zfs
5149 zvols need a way to ignore DKIOCFREE
https://reviews.csiden.org/r/92/
Is there a use case where this policy should be per-zvol instead of global?

-- richard
Post by Matthew Ahrens via illumos-zfs
--matt
illumos-zfs | Archives | Modify Your Subscription
-------------------------------------------
illumos-zfs
Archives: https://www.listbox.com/member/archive/182191/=now
RSS Feed: https://www.listbox.com/member/archive/rss/182191/23047029-187a0c8d
Modify Your Subscription: https://www.listbox.com/member/?member_id=23047029&id_secret=23047029-2e85923f
Powered by Listbox: http://www.listbox.com
Matthew Ahrens via illumos-zfs
2014-09-11 15:32:33 UTC
Permalink
On Sep 10, 2014, at 9:43 PM, "Matthew Ahrens via illumos-zfs" <
5149 zvols need a way to ignore DKIOCFREE
https://reviews.csiden.org/r/92/
Is there a use case where this policy should be per-zvol instead of global?
Maybe? I'm sure you could create a use case where it is. But I doubt it
would be worth the effort to implement that, especially now that
performance of DKIOCFREE has been much improved (by the fix for 4873).

--matt



-------------------------------------------
illumos-zfs
Archives: https://www.listbox.com/member/archive/182191/=now
RSS Feed: https://www.listbox.com/member/archive/rss/182191/23047029-187a0c8d
Modify Your Subscription: https://www.listbox.com/member/?member_id=23047029&id_secret=23047029-2e85923f
Powered by Listbox: http://www.listbox.com
Richard Elling via illumos-zfs
2014-09-11 18:09:46 UTC
Permalink
Post by Richard Elling via illumos-zfs
Post by Matthew Ahrens via illumos-zfs
5149 zvols need a way to ignore DKIOCFREE
https://reviews.csiden.org/r/92/
Is there a use case where this policy should be per-zvol instead of global?
Maybe? I'm sure you could create a use case where it is. But I doubt it would be worth the effort to implement that, especially now that performance of DKIOCFREE has been much improved (by the fix for 4873).
Agree. Let's start here and worry about per-zvol later, if needed.
-- richard
Post by Richard Elling via illumos-zfs
--matt
_______________________________________________
developer mailing list
http://lists.open-zfs.org/mailman/listinfo/developer
-------------------------------------------
illumos-zfs
Archives: https://www.listbox.com/member/archive/182191/=now
RSS Feed: https://www.listbox.com/member/archive/rss/182191/23047029-187a0c8d
Modify Your Subscription: https://www.listbox.com/member/?member_id=23047029&id_secret=23047029-2e85923f
Powered by Listbox: http://www.listbox.com

Loading...