Discussion:
4369 implement zfs bookmarks and 4368 zfs send filesystems from readonly pools
Christopher Siden
2013-12-01 19:48:20 UTC
Permalink
http://code.delphix.com/illumos-4369/

Work by Matt Ahrens. See bug reports and man page changes for details.

Chris
Saso Kiselkov
2013-12-01 20:01:30 UTC
Permalink
Post by Christopher Siden
http://code.delphix.com/illumos-4369/
Work by Matt Ahrens. See bug reports and man page changes for details.
Nice work.

One quick observation: zfeature_common.[hc] list some features not in
public Illumos (SPA_FEATURE_ENABLED_TXG, SPA_FEATURE_HOLE_BIRTH). Have
you webrev'ed from some private tree or branch?

Cheers,
--
Saso
Christopher Siden
2013-12-01 20:53:04 UTC
Permalink
I prepared the webrev on top of '4370 avoid transmitting holes during
zfs send', which I just put out for review in a separate mail. The two
features don't strictly depend on each other, but it reduces merge
conflicts to push 4370 first.
Post by Saso Kiselkov
Post by Christopher Siden
http://code.delphix.com/illumos-4369/
Work by Matt Ahrens. See bug reports and man page changes for details.
Nice work.
One quick observation: zfeature_common.[hc] list some features not in
public Illumos (SPA_FEATURE_ENABLED_TXG, SPA_FEATURE_HOLE_BIRTH). Have
you webrev'ed from some private tree or branch?
Cheers,
--
Saso
-------------------------------------------
illumos-zfs
Archives: https://www.listbox.com/member/archive/182191/=now
RSS Feed: https://www.listbox.com/member/archive/rss/182191/21639088-b97104e3
Modify Your Subscription: https://www.listbox.com/member/?&
Powered by Listbox: http://www.listbox.com
Bill Sommerfeld
2013-12-01 21:39:18 UTC
Permalink
Post by Christopher Siden
http://code.delphix.com/illumos-4369/
I think there's an error in the change to usr/src/man/man1m/zfs.1m:

"Generate a send stream, which may be of a filesystem, and
may be incremental from a bookmark. If the destination is
a filesystem or volume, the pool must be read-only, or the
filesystem must not be mounted. "

The word "destination" doesn't really make sense here. Did you intend
to say "source" instead?
Matthew Ahrens
2013-12-04 02:05:18 UTC
Permalink
Post by Bill Sommerfeld
Post by Christopher Siden
http://code.delphix.com/illumos-4369/
"Generate a send stream, which may be of a filesystem, and
may be incremental from a bookmark. If the destination is
a filesystem or volume, the pool must be read-only, or the
filesystem must not be mounted. "
The word "destination" doesn't really make sense here. Did you intend to
say "source" instead?
No; the source can not be a filesystem or volume. "destination" in this
context means "the thing that is being sent", as contrasted with the
incremental "source" -- we are sending an incremental from "source" to
"destination" (zfs send -i <source> <destination>). "target" might be a
better word to use here, although there is some precedent for "destination":

If the destination is a clone, the source may be the
origin snapshot, which must be fully specified (for
example, pool/***@origin, not just @origin).

--matt
Post by Bill Sommerfeld
-------------------------------------------
illumos-zfs
Archives: https://www.listbox.com/member/archive/182191/=now
RSS Feed: https://www.listbox.com/member/archive/rss/182191/
21635000-ebd1d460
Modify Your Subscription: https://www.listbox.com/
member/?&
Powered by Listbox: http://www.listbox.com
-------------------------------------------
illumos-zfs
Archives: https://www.listbox.com/member/archive/182191/=now
RSS Feed: https://www.listbox.com/member/archive/rss/182191/23047029-187a0c8d
Modify Your Subscription: https://www.listbox.com/member/?member_id=23047029&id_secret=23047029-2e85923f
Powered by Listbox: http://www.listbox.com

Loading...