Discussion:
Fix for small memory leak in ztest_init
Richard Yao
2014-03-10 20:34:33 UTC
Permalink
I caught a small memory leak in ztest_init on ZoL, which appears to
apply to Illumos.

https://github.com/ryao/zfs/commit/ca200e913fbaf9c68c7ee43b2e073e661b5a1180

This is part of a pull request with ZoL:

https://github.com/zfsonlinux/zfs/pull/2174

This is a simple one liner. Do I need to go through the webrev process
to share this with Illumos (and by extension FreeBSD)?




-------------------------------------------
illumos-zfs
Archives: https://www.listbox.com/member/archive/182191/=now
RSS Feed: https://www.listbox.com/member/archive/rss/182191/23047029-187a0c8d
Modify Your Subscription: https://www.listbox.com/member/?member_id=23047029&id_secret=23047029-2e85923f
Powered by Listbox: http://www.listbox.com
Xin Li
2014-03-11 00:41:53 UTC
Permalink
Post by Richard Yao
I caught a small memory leak in ztest_init on ZoL, which appears
to apply to Illumos.
https://github.com/ryao/zfs/commit/ca200e913fbaf9c68c7ee43b2e073e661b5a1180
https://github.com/zfsonlinux/zfs/pull/2174
LGTM.

Cheers,
- --
Xin LI <***@delphij.net> https://www.delphij.net/
FreeBSD - The Power to Serve! Live free or die
Matthew Ahrens
2014-03-13 09:00:19 UTC
Permalink
Looks good to me. My understanding is that the requirement is to have the
code reviewed, not necessarily to use webrev. You will need to build &
test on illumos, though.

--matt
Post by Richard Yao
I caught a small memory leak in ztest_init on ZoL, which appears to
apply to Illumos.
https://github.com/ryao/zfs/commit/ca200e913fbaf9c68c7ee43b2e073e661b5a1180
https://github.com/zfsonlinux/zfs/pull/2174
This is a simple one liner. Do I need to go through the webrev process
to share this with Illumos (and by extension FreeBSD)?
-------------------------------------------
illumos-zfs
Archives: https://www.listbox.com/member/archive/182191/=now
https://www.listbox.com/member/archive/rss/182191/21635000-ebd1d460
https://www.listbox.com/member/?&
Powered by Listbox: http://www.listbox.com
-------------------------------------------
illumos-zfs
Archives: https://www.listbox.com/member/archive/182191/=now
RSS Feed: https://www.listbox.com/member/archive/rss/182191/23047029-187a0c8d
Modify Your Subscription: https://www.listbox.com/member/?member_id=23047029&id_secret=23047029-2e85923f
Powered by Listbox: http://www.listbox.com

Loading...